Merged
Conversation
rhayes777
reviewed
May 16, 2025
|
|
||
|
|
||
|
|
||
| class dPIE(MassProfile): |
Collaborator
There was a problem hiding this comment.
It's odd having a lowercase class name I'd call it DPIE
Contributor
There was a problem hiding this comment.
It is certainly odd, but the "dPIE" capitalization is standard for this profile. The original Eliasdottir 07 paper used this convention, and most cluster lensing work keeps with it (here's two random papers which use "dPIE": Bergamini 2019, Acebron 2025).
Whether you want to keep that capitalization in the API, as opposed to technical writing, is I guess another matter. But I'd stick with "dPIE" for consistency with other work.
| grid = ag.Grid2DIrregular([[1.0, 1.0], [2.0, 2.0], [3.0, 3.0], [2.0, 4.0]]) | ||
|
|
||
|
|
||
| def test__deflections_yx_2d_from(): |
Collaborator
There was a problem hiding this comment.
Some day you'll learn how nice parametrize is :')
Contributor
|
Thanks James for implementing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the
dPIEdual pseudo Isothermal mass profile, commonly used to model addition galaxies in groups and cluster scale lenses.Thank you @jhod0 for providing this code, which I refactored into a more autolens-y grid API but will simplify in the near future based on your feedback on using the source code!